Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gn: 20181031 -> 20190726 #65524

Merged
merged 1 commit into from Jul 29, 2019
Merged

gn: 20181031 -> 20190726 #65524

merged 1 commit into from Jul 29, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates gn to the latest commit. This includes a commit that fixes the build on 32-bit ARM: https://gn.googlesource.com/gn.git/+/01237e9cd0f7e4e1bd4f09a7971b4eb9b8a3c390

cc @stesie @matthewbauer

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from matthewbauer July 28, 2019 20:19
@mmahut
Copy link
Member

mmahut commented Jul 28, 2019

@GrahamcOfBorg build gn

@Mic92 Mic92 merged commit a5542ce into NixOS:master Jul 29, 2019
@delroth
Copy link
Contributor

delroth commented Jul 30, 2019

I think this broke the chromium build? It's in range for https://hydra.nixos.org/build/97304567

@lopsided98
Copy link
Contributor Author

Yes, it did. It appears that they purposely broke backwards compatibility even though they knew it would break chromium: https://gn-review.googlesource.com/c/gn/+/4980

We should probably do what Arch Linux does, and use the commit specified in the Chromium repository. See: https://git.archlinux.org/svntogit/packages.git/tree/trunk/chromium-gn-version.sh?h=packages/gn

I will submit a PR for this in a few minutes.

@lopsided98
Copy link
Contributor Author

#65587 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @mmahut @delroth @Mic92