Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librecad-git: add -git version that supports qt5 #65523

Closed
wants to merge 1 commit into from
Closed

librecad-git: add -git version that supports qt5 #65523

wants to merge 1 commit into from

Conversation

yvesf
Copy link
Member

@yvesf yvesf commented Jul 28, 2019

Motivation for this change

Provide a git-version that is qt5 compatible while there is no released version supporting qt5.

Things done
  • Tested using sandboxing (nixos variant) (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yvesf
Copy link
Member Author

yvesf commented Jan 21, 2020

closing, this problem is fixed by the change in #69077
but it feels a bit strange how this PR went basically unnoticed and I couldn't made anything to get it merged. Later the other one got merged by the author without even a review (there is one requested but apparently not approved).

@yvesf yvesf closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yvesf @Janik-Haag