Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nim: 0.20.0 -> 0.20.2 #65421

Merged
merged 1 commit into from Jul 28, 2019
Merged

nim: 0.20.0 -> 0.20.2 #65421

merged 1 commit into from Jul 28, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

maintainers: @ehmry @peterhoeg

/nix/store/v2wx8k0zcg47paiac60v950lpwzcr8g3-nim-0.20.0	 233.7M
/nix/store/8vyg93hwqmadzr5l327c5sjrrl6n275w-nim-0.20.2	 233.9M

pbb@uwu ~/nixpkgs> nix-shell -p nix-review --run "nix-review wip"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
$ git worktree add /home/pbb/.cache/nix-review/rev-fcd940feb1b313da7f8b912214241a87c3512bde-dirty/nixpkgs f7579996c712b52aca134beb53f6a333f91a429f
Preparing worktree (detached HEAD f7579996c71)
Checking out files: 100% (19451/19451), done.
HEAD is now at f7579996c71 Merge pull request #62566 from r-ryantm/auto-update/serviio
$ nix-env -f /home/pbb/.cache/nix-review/rev-fcd940feb1b313da7f8b912214241a87c3512bde-dirty/nixpkgs -qaP --xml --out-path --show-trace
Applying `nixpkgs` diff...
$ nix-env -f /home/pbb/.cache/nix-review/rev-fcd940feb1b313da7f8b912214241a87c3512bde-dirty/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/pbb/.cache/nix-review/rev-fcd940feb1b313da7f8b912214241a87c3512bde-dirty/build.nix
[3 built, 7 copied (7.1 MiB), 2.7 MiB DL]
3 package were build:
mosdepth nim nrpl

[0.0 MiB DL]
$ nix-shell /home/pbb/.cache/nix-review/rev-fcd940feb1b313da7f8b912214241a87c3512bde-dirty/shell.nix
[nix-shell:~/.cache/nix-review/rev-fcd940feb1b313da7f8b912214241a87c3512bde-dirty]$ exit
$ git worktree prune
pbb@uwu ~/nixpkgs>

@mmahut
Copy link
Member

mmahut commented Jul 27, 2019

@GrahamcOfBorg build nim

peterhoeg
peterhoeg reviewed Jul 28, 2019
View reviewed changes
pkgs/development/compilers/nim/default.nix
@@ -105,7 +105,7 @@ stdenv.mkDerivation rec {

meta = with stdenv.lib; {
description = "Statically typed, imperative programming language";
homepage = https://nim-lang.org/;
homepage = "https://nim-lang.org/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for turning this into a string?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterhoeg NixOS/rfcs#45

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of that - thanks!

@peterhoeg peterhoeg merged commit 2c12445 into NixOS:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @peterhoeg