Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_server: 3.8.0 -> 3.9.1 #65422

Merged
merged 1 commit into from Aug 12, 2019
Merged

teamspeak_server: 3.8.0 -> 3.9.1 #65422

merged 1 commit into from Aug 12, 2019

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Jul 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/20i3j8j5abcf89jq58gbnggmm03r8vk1-teamspeak-server-3.8.0	   53437952
/nix/store/syk9rscfn48py1yxj4cwkwg957qmi26z-teamspeak-server-3.9.1	   53523008

angristan
angristan approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with nix-review: build and run of the 2 binaries ✔️

mmahut
mmahut approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals properly
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit 92f6cf6 into NixOS:master Aug 12, 2019
@jojosch jojosch deleted the teamspeak_server_3.9.1 branch August 12, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@angristan angristan angristan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jojosch @mmahut @angristan @Janik-Haag