Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscad: not using qt5 and libsForQt5 directly #65531

Merged
merged 1 commit into from Jul 29, 2019
Merged

openscad: not using qt5 and libsForQt5 directly #65531

merged 1 commit into from Jul 29, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 28, 2019 •
edited

Motivation for this change

Additional fix for #65522.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

This would fail to build unless I called it with libsForQt5 and not qt5...

Guess we should switch it to that?

@worldofpeace worldofpeace merged commit a1fc5b4 into NixOS:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@bjornfor bjornfor Awaiting requested review from bjornfor

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @worldofpeace