Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartgithg: 18.2.4 -> 18.2.9 #65473

Merged
merged 1 commit into from Aug 4, 2019
Merged

smartgithg: 18.2.4 -> 18.2.9 #65473

merged 1 commit into from Aug 4, 2019

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Jul 27, 2019 •
edited

Motivation for this change

Upgrade smartgithg to 18.2.9 and adds wrapGAppsHook.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@megheaiulian
Copy link
Contributor Author

@worldofpeace I've done a bunch of other changes and modernized the derivation a bit.
Please have a look!

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 3, 2019 •
edited

@worldofpeace I've done a bunch of other changes and modernized the derivation a bit.
Please have a look!

Looks great 😄
Can you document the changes in the commit body? (even just plain bullet points should be fine)

@megheaiulian
smartgithg: 18.2.4 -> 18.2.9
c089c15 
Refactored packages:
  * adds makeDesktopItem and remove install_freedesktop_items
  * replaced buildCommand with preFixup & installPhase
  * replaces makeWrapper with wrapGAppsHook
@megheaiulian
Copy link
Contributor Author

@worldofpeace Updated the PR with requested changes.

worldofpeace
worldofpeace approved these changes Aug 4, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@worldofpeace worldofpeace merged commit f646d1c into NixOS:master Aug 4, 2019
@megheaiulian megheaiulian deleted the feature/smartgithg branch August 4, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@megheaiulian @worldofpeace