Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-fast-syntax-highlighting:init at 1.54 #65429

Merged
merged 2 commits into from Nov 20, 2019
Merged

zsh-fast-syntax-highlighting:init at 1.54 #65429

merged 2 commits into from Nov 20, 2019

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Jul 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/67

@timokau
Copy link
Member

timokau commented Nov 9, 2019

Thank you for your contribution, but please keep "PRs already reviewed" to only those PRs that have actually been reviewed ;)

@pasqui23 pasqui23 changed the title zsh-fast-syntax-highlighting:init at 2019-07-20 zsh-fast-syntax-highlighting:init at 15.4 Nov 19, 2019
@pasqui23 pasqui23 changed the title zsh-fast-syntax-highlighting:init at 15.4 zsh-fast-syntax-highlighting:init at 1.54 Nov 19, 2019
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash all commits:

git reset HEAD~6
git add pkgs/
git commit --amend --no-edit
git push --force <fork> <branch>

@veprbl
Copy link
Member

veprbl commented Nov 20, 2019

@GrahamcOfBorg build zsh-fast-syntax-highlighting

@veprbl
Copy link
Member

veprbl commented Nov 20, 2019

@pasqui23 I took liberty to further simplify the expression. The "cd $src" line is actually not needed after unpackPhase creates a copy of the source code and harmful in cases when user tries to add patches or override src to point to a tarball. Also "install -m644" doesn't do anything for us, the write bit will be reset by Nix for files in the store. An "install -m444" would be fine, but we are already doing "cp" on some directories, so we might as well stick with it.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on NixOS, highlighting works.

@veprbl veprbl merged commit c20f765 into NixOS:master Nov 20, 2019
@veprbl veprbl removed their assignment Nov 23, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 18, 2020
@lucc
Copy link
Contributor

lucc commented Jun 16, 2021

@veprbl sorry to bother you in this old issue but how did you use the package? Did you just do

{
  programs.zsh.interactiveShellInit = ''
    source ${pkgs.zsh-fast-syntax-highlighting}/share/zsh/site-functions/fast-syntax-highlighting.plugin.zsh
  '';
}

in your configuration.nix or is there a better way?

@veprbl
Copy link
Member

veprbl commented Jun 16, 2021

@lucc, I never set this up on my system, just tested that it works to "source" it in zsh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants