purple-matrix: pname, fix cflags, restore hardening #65427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jul 26, 2019
| hardeningDisable = [ "fortify" ]; # upstream compiles with -O0 | ||
| # Drop bad CFLAGS | ||
| postPatch = '' | ||
| substituteInPlace Makefile.common --replace "-O0 -Werror" "" |
There was a problem hiding this comment.
Does this work?
NIX_CFLAGS_COMPILE = ["-O3" "-Wno-error"];
This would be more robust then sed patching.
dtzWill
force-pushed
the
update/purple-matrix
branch
from
6655aaa
to
d05037e
Compare
symphorien
approved these changes
Oct 8, 2019
|
Is the |
1 similar comment
|
Is the |
dtzWill
force-pushed
the
update/purple-matrix
branch
from
d05037e
to
e651f5d
Compare
|
Dropped build system touchup, letting NIX_CFLAGS_COMPILE additions override the Benefit of this approach is it's less likely (I'd guess) to need attention in a future update :). I don't really have any preference, just explaining since was revisiting to address comment I missed for some time O:). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Also bump to latest, although not sure the changes are significant
functionally.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)