Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjpeg_1: disable tests #65428

Closed
wants to merge 1 commit into from
Closed

openjpeg_1: disable tests #65428

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2019

Motivation for this change

3e5ccd4 broke tests for openjpeg_1 since tests are only properly supported for openjpeg_2 but enabled in versions 1 and 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jul 26, 2019

CC @codyopel @risicle

@ghost
Copy link
Author

ghost commented Jul 26, 2019

fixes #65420

@risicle
Copy link
Contributor

risicle commented Jul 26, 2019

Well caught @petabyteboy - WFM, non-nixos x86_64.

Looking back at the original PR, I added this because the list of reverse dependencies for openjpeg was so huge as to make nox-review impractical to run. Which is why I didn't check it. Irony of ironies.

@worldofpeace
Copy link
Contributor

someone already pushed a fix to master fdf08ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @worldofpeace