Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.configshell: Add urwid to deps #65502

Merged
merged 1 commit into from Jul 28, 2019
Merged

pythonPackages.configshell: Add urwid to deps #65502

merged 1 commit into from Jul 28, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

It's required in
https://github.com/open-iscsi/configshell-fb/blob/master/configshell/node.py#L1062
and crashes when reaching the function with that import.

Reproduce with:

  1. Open targetcli
  2. Execute a plain cd without a path.
> nix-shell -p targetcli --run targetcli
targetcli shell version 2.1.fb49
Copyright 2011-2013 by Datera, Inc and others.
For help on commands, type 'help'.

You are not root, disabling privileged commands.

/> cd
Traceback (most recent call last):
  File "/nix/store/v8jymljdrangfpj03rs50a48ymmpmmqm-targetcli-2.1.fb49/bin/.targetcli-wrapped", line 123, in <module>
    main()
  File "/nix/store/v8jymljdrangfpj03rs50a48ymmpmmqm-targetcli-2.1.fb49/bin/.targetcli-wrapped", line 113, in main
    shell.run_interactive()
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/shell.py", line 905, in run_interactive
    self._cli_loop()
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/shell.py", line 734, in _cli_loop
    self.run_cmdline(cmdline)
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/shell.py", line 848, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/shell.py", line 823, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/node.py", line 1406, in execute_command
    return method(*pparams, **kparams)
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/node.py", line 1028, in ui_command_cd
    selected = self._lines_walker(lines, start_pos=start_pos)
  File "/nix/store/h2306py2z6xs9gpfplm1vd25p1xirbvk-python2.7-configshell-1.1.fb25/lib/python2.7/site-packages/configshell_fb/node.py", line 1062, in _lines_walker
    import urwid
ImportError: No module named urwid
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 28, 2019

@GrahamcOfBorg build targetcli

@FRidh FRidh merged commit a96b70b into NixOS:master Jul 28, 2019
@JohnAZoidberg JohnAZoidberg deleted the configshell-urwid branch July 28, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @FRidh