Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: 1.6.3 -> 1.7.0 #65501

Closed
wants to merge 3 commits into from
Closed

qutebrowser: 1.6.3 -> 1.7.0 #65501

wants to merge 3 commits into from

Conversation

k0ral
Copy link
Contributor

@k0ral k0ral commented Jul 28, 2019 •
edited

Motivation for this change

Upgrade qutebrowser to latest version.

Things done

Upgraded sip and pyqt5 dependencies as well.
Could not test execution of qutebrowser as it fails with No module named 'PyQt5.QtQml' error on my side; it used to fail with the same error before the upgrade to 1.7.0 so this is not related to this pull-request. This pull-request was actually an attempt at fixing this error, but even though it doesn't, the upgrade is still desirable.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@k0ral k0ral requested a review from FRidh as a code owner July 28, 2019 09:18
FRidh
FRidh requested changes Jul 28, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply bumping versions is not enough here.
#65448

@FRidh
Copy link
Member

FRidh commented Jul 28, 2019

duplicate of #65150

@FRidh FRidh closed this Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@jagajaga jagajaga Awaiting requested review from jagajaga

@lovek323 lovek323 Awaiting requested review from lovek323

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k0ral @FRidh