@GrahamcOfBorg build minikube

Sorry for hijacking this PR, this is not an issue with this PR itself, it's much larger.

We're accepting more and more packages using buildGoModule in nixpkgs even though there is an expressed intent to restrict what we can do with fixed output derivations.
This is at odds and I can't see much reason we keep accepting packages being converted over and making any future efforts to restrict FODs more difficult.

I'd like us to stop accepting new packages that are abusing FODs and start working on gradually removing these abuses.
See NixOS/nix#2270.

cc @Mic92 @kalbasit

nix-review fails for me:

builder for '/nix/store/ghpzc56myn409xbx7b22kspbv2xg726b-docker-machine-kvm2-1.2.0.drv' failed with exit code 1; last 10 log lines:
        /build/go/src/k8s.io/client-go/tools/clientcmd/api (from $GOPATH)
  go/src/k8s.io/minikube/pkg/util/kubeconfig.go:33:2: cannot find package "k8s.io/client-go/tools/clientcmd/api/latest" in any of:
        /nix/store/ivsk24l5dsdlyx92mnvkp4075hzpjfpj-go-1.12.7/share/go/src/k8s.io/client-go/tools/clientcmd/api/latest (from $GOROOT)
        /build/go/src/k8s.io/client-go/tools/clientcmd/api/latest (from $GOPATH)
  go/src/k8s.io/minikube/pkg/minikube/constants/constants.go:30:2: cannot find package "k8s.io/client-go/util/homedir" in any of:
        /nix/store/ivsk24l5dsdlyx92mnvkp4075hzpjfpj-go-1.12.7/share/go/src/k8s.io/client-go/util/homedir (from $GOROOT)
        /build/go/src/k8s.io/client-go/util/homedir (from $GOPATH)
  go/src/k8s.io/minikube/pkg/util/kubernetes.go:38:2: cannot find package "k8s.io/kubernetes/cmd/kubeadm/app/constants" in any of:
        /nix/store/ivsk24l5dsdlyx92mnvkp4075hzpjfpj-go-1.12.7/share/go/src/k8s.io/kubernetes/cmd/kubeadm/app/constants (from $GOROOT)
        /build/go/src/k8s.io/kubernetes/cmd/kubeadm/app/constants (from $GOPATH)
builder for '/nix/store/mci9nxq9ccamgw4r8lw7pa72qlf5ysfg-minikube-1.2.0.drv' failed with exit code 1; last 10 log lines:
  k8s.io/minikube/pkg/minikube/logs
  k8s.io/minikube/pkg/minikube/notify
  k8s.io/minikube/pkg/minikube/tunnel
  k8s.io/minikube/third_party/go9p
  k8s.io/minikube/third_party/go9p/ufs
  k8s.io/minikube/cmd/minikube/cmd
  k8s.io/minikube/cmd/minikube
  glibPreInstallPhase
  installing
  mkdir: cannot create directory '/share': Permission denied
cannot build derivation '/nix/store/sr212h8lfpn9l1gv0yn92q32hfr78yw9-env.drv': 2 dependencies couldn't be built

I don't know enough about the particular builder but it seems like $bin isn't being set correctly.

Sorry for hijacking this PR, this is not an issue with this PR itself, it's much larger.

We're accepting more and more packages using buildGoModule in nixpkgs even though there is an expressed intent to restrict what we can do with fixed output derivations.
This is at odds and I can't see much reason we keep accepting packages being converted over and making any future efforts to restrict FODs more difficult.

I'd like us to stop accepting new packages that are abusing FODs and start working on gradually removing these abuses.
See NixOS/nix#2270.

cc @Mic92 @kalbasit

Thanks for the pointer, I have missed this issue. I don't think we should worry about that now. It's an issue today, and won't be resolved for a long while. Until then, we should do business as usual. Whatever the solution will be, it will have to take into account the current packages by either changing buildGoModule itself, or via a script to fix them all -- in which case converting/adding more packages won't matter as much.

@GrahamcOfBorg build minikube

@adisbladis I do not see this being the case, there's a discussion how to solve this issue, but until better solution is found, we rather have a way to have packages updated, as to stop packaging.

PS: and you can also see that many people disagree with proposed restrictions, as there are currently only bad alternatives

@GrahamcOfBorg build minikube

Darwin failure is unrelated, seems like clang is failing