Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggregateModules: fix x-compilation for out-of-tree kernel modules #65535

Merged
merged 1 commit into from Jul 29, 2019
Merged

aggregateModules: fix x-compilation for out-of-tree kernel modules #65535

merged 1 commit into from Jul 29, 2019

Conversation

lukateras
Copy link
Member

Motivation for this change

Allows to cross-compile NixOS when boot.extraModulePackages is set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jul 29, 2019

this looks reasonable. How could I check it works from my system: x86_64-linux", multi-user?: yes, version: nix-env (Nix) 2.2.2 machine ?

@lukateras
Copy link
Member Author

Hm, I tested this by cross-compiling NixOS Ext4 install image to aarch64-linux, but this is certainly not a minimal repro.

@Mic92 Mic92 merged commit ad1cce2 into NixOS:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @teto @Mic92