Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnutls: 3.6.8 -> 3.6.9 #65406

Merged
merged 1 commit into from Jul 28, 2019
Merged

gnutls: 3.6.8 -> 3.6.9 #65406

merged 1 commit into from Jul 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 26, 2019

Motivation for this change

https://gitlab.com/gnutls/gnutls/blob/gnutls_3_6_9/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Still rebuilding my machines against it, but so far so good...

@vcunat vcunat self-assigned this Jul 28, 2019
vcunat
vcunat approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS looks safe, and their maintenance releases generally are. I briefly tried some reverse deps.

@vcunat vcunat merged commit e309ddb into NixOS:staging Jul 28, 2019
vcunat added a commit that referenced this pull request Jul 28, 2019
@vcunat
Merge #65406: gnutls: 3.6.8 -> 3.6.9 (into staging)
507dfa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @vcunat