Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.mongodb: init at 1.5.5 #65401

Merged
merged 1 commit into from Aug 11, 2019
Merged

phpPackages.mongodb: init at 1.5.5 #65401

merged 1 commit into from Aug 11, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse marked this pull request as ready for review August 8, 2019 19:43
@aanderse aanderse requested review from etu and Ma27 August 8, 2019 19:43
@aanderse
Copy link
Member Author

aanderse commented Aug 8, 2019

@GrahamcOfBorg build php72Packages.mongodb

etu
etu approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows the style as other php packages and builds fine. So it seems good to me.

Ma27
Ma27 approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine, also built and tested locally 👍

@Ma27 Ma27 merged commit 142d2f8 into NixOS:master Aug 11, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 11, 2019

@aanderse thanks!

@aanderse aanderse deleted the php-mongodb-driver branch August 11, 2019 12:52
@aanderse
Copy link
Member Author

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Ma27 @etu