Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhcpcd: 7.2.3 -> 8.0.2 #65403

Merged
merged 2 commits into from Aug 13, 2019
Merged

dhcpcd: 7.2.3 -> 8.0.2 #65403

merged 2 commits into from Aug 13, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 26, 2019 •
edited

Motivation for this change

https://roy.marples.name/blog/dhcpcd-8-0-0-released
https://roy.marples.name/blog/dhcpcd-8-0-1-released
https://roy.marples.name/blog/dhcpcd-8-0-2-released

Haven't checked the tests yet, should definitely check before proceeding
:).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jul 27, 2019

As I have a non-trivial dhcpcd configuration on my main workstation, I'd like to test this before having this merged (if I have sufficient time, I'd do this tomorrow :) )

Ma27
Ma27 reviewed Jul 28, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested my personal setup with dhcpcd 8.0.1. In contrast to a traditional setup it doesn't set a default gateway and a default DNS server. Instead I use a local resolver and an always-on VPN and set routes to the VPN endpoint in an exit hook (see dhcpcd-run-hooks(8) for further reference). I just used this change for half a day and tested several scenarios including reboots and network changes and I didn't encounter any regressions. Also tested nixos.tests.networking.scripted.privacy.x86_64-linux, nixos.tests.networking.scripted.dhcpSimple.x86_64-linux and nixos.tests.networking.scripted.macvlan.x86_64-linux.

However it would be awesome to have some more people who could test this :)

@dtzWill
dhcpcd: 8.0.1 -> 8.0.2
a8e9dc7 
https://roy.marples.name/blog/dhcpcd-8-0-2-released

> I don't anticipate any more releases for a while as this is looking
really good now!
@dtzWill dtzWill changed the title dhcpcd: 7.2.3 -> 8.0.1 dhcpcd: 7.2.3 -> 8.0.2 Jul 30, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Jul 30, 2019

Upstream notes 8.0.2 is last expected release for a bit, since things are apparently looking good now (paraphrased from release notes linked above :)).

@ofborg ofborg bot requested review from edolstra and fpletz July 30, 2019 22:51
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg test networking

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

I did test it a little, looks to be fine.

@mmahut mmahut merged commit 61ea45d into NixOS:staging Aug 13, 2019
@dtzWill dtzWill deleted the update/dhcpcd-8.0.1 branch August 21, 2019 20:05
@dtzWill dtzWill mentioned this pull request Aug 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@edolstra edolstra Awaiting requested review from edolstra

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Ma27 @mmahut