Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termdown: 1.15.0 -> 1.16.0 #65408

Merged
merged 1 commit into from Jul 26, 2019
Merged

termdown: 1.15.0 -> 1.16.0 #65408

merged 1 commit into from Jul 26, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 26, 2019

Motivation for this change

Minor update:
https://github.com/trehn/termdown/blob/1.16.0/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@Mic92 Mic92 merged commit 732163d into NixOS:master Jul 26, 2019
@riotbib
Copy link
Member

riotbib commented Mar 10, 2020

Hi, I tried installing termdown via nix-shell -p termdown, the following bug occurred when executing termdown:

ImportError: No module named pkg_resources

Thus, it seems python3Packages.setuputils is missing (on my machine). Could you add it in the default.nix's propagatedBuildInputs or is there good reason not to include it?

(I am not proficient enough to do the PR right now, sorry.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @riotbib @mmahut @Mic92