Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd: 1.4.1 -> 1.4.2 #65409

Merged
merged 1 commit into from Aug 19, 2019
Merged

zstd: 1.4.1 -> 1.4.2 #65409

merged 1 commit into from Aug 19, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 26, 2019

Motivation for this change

https://github.com/facebook/zstd/releases/tag/v1.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 30, 2019

Seems unrelated?

@GrahamcOfBorg eval
@GrahamcOfBorg build zstd
@GrahamcOfBorg build squashfs casync

@orivej-nixos orivej-nixos changed the base branch from staging to master August 19, 2019 13:48
@orivej-nixos orivej-nixos merged commit 93a514a into NixOS:master Aug 19, 2019
@dtzWill dtzWill mentioned this pull request Aug 19, 2019
Merged
10 tasks
@dtzWill dtzWill deleted the update/zstd-1.4.2 branch August 19, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @orivej-nixos