Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bukubrow: 2.4.0 -> 5.0.0 #65489

Merged
merged 1 commit into from Sep 9, 2019
Merged

bukubrow: 2.4.0 -> 5.0.0 #65489

merged 1 commit into from Sep 9, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jul 28, 2019

Motivation for this change

Seems like this hasn't been touched in a while? Unfortunately it tries to be smart and generates the json on-demand and guesses where it should go and I'm not even going to begin to try using that in the build so I've just included the files themselves. Could use toJSON instead if anyone wants it to be fancy I guess?

Not entirely sure about the chromium path, chrome docs say to use /etc/chromium but I've only tested with firefox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from infinisil July 28, 2019 02:04
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build bukubrow

@arcnmx how could I test this, please?

@arcnmx
Copy link
Member Author

arcnmx commented Aug 12, 2019 •
edited

Something like...

nix run '((import <nixpkgs> {config.firefox.enableBukubrow = true;}).firefox)' -c firefox

and installing the extension from AMO should work

Note that doing this with upstream nixpkgs (and bukubrow 2.4.0) will result in the extension complaining about the host app being out of date.

@arcnmx
Copy link
Member Author

arcnmx commented Sep 8, 2019

Resolved conflict, and also inlined the json because it seemed slightly neater.

cc @infinisil

@infinisil infinisil merged commit 6128371 into NixOS:master Sep 9, 2019
@infinisil
Copy link
Member

Nice!

@arcnmx arcnmx deleted the pr-bukubrow-update branch November 26, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @mmahut @infinisil