Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb: fix build on aarch64 #65504

Merged
merged 1 commit into from Jul 29, 2019
Merged

mongodb: fix build on aarch64 #65504

merged 1 commit into from Jul 29, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

MongoDB currently fails to build on aarch64 because WiredTiger fails to compile without crc extensions on aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (aarch64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test mongodb

mmahut
mmahut approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms, tests are running fine
  • run nix-review without any failures
  • run and tested the binaries

@Mic92 Mic92 merged commit 94de28b into NixOS:master Jul 29, 2019
@WilliButz WilliButz deleted the fix-mongodb-aarch64 branch July 29, 2019 10:07
@WilliButz WilliButz mentioned this pull request Aug 12, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @mmahut @Mic92