Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-sdk: 241.0.0 -> 255.0.0 #65417

Merged
merged 1 commit into from Jul 28, 2019
Merged

google-cloud-sdk: 241.0.0 -> 255.0.0 #65417

merged 1 commit into from Jul 28, 2019

Conversation

sveitser
Copy link
Contributor

Motivation for this change

Package update.

Fixes this issue with google cloud run: https://stackoverflow.com/questions/57031471/gcloud-crashed-attributeerror-nonetype-object-has-no-attribute-revisiontem for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sveitser
Copy link
Contributor Author

Ping @stephenmw @zimbatm

@ofborg ofborg bot requested a review from zimbatm July 26, 2019 13:54
@zimbatm
Copy link
Member

zimbatm commented Jul 26, 2019

Did you check if any of the installPhase needed to be updated? that phase is pretty heavy and depends on the source internals so some things might have changed since the last release.

@sveitser
Copy link
Contributor Author

I'm not familiar with the package and am only using it for google cloud run.

I think the installPhase still makes sense but probably wouldn't know if it didn't.

  • There haven't been any changes to install.sh or the scripts in the bin folder between the two versions.
  • The flags component_manger.disable_update_check and disable_updater are still present.

I checked that executing the help commands for all the wrapped programs (gcloud bq gsutil git-credential-gcloud.sh docker-credential-gcloud) as well as gcloud alpha and gcloud beta (for which there are custom __init__.py) still works on NixOS and darwin.

Let me know if there's anything else I should test or look at.

@zimbatm zimbatm merged commit c6e7bc2 into NixOS:master Jul 28, 2019
@zimbatm
Copy link
Member

zimbatm commented Jul 28, 2019

thanks! I think that's enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sveitser @zimbatm