Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poezio: 0.12 -> 0.12.1 #65529

Merged
merged 1 commit into from Jul 29, 2019
Merged

poezio: 0.12 -> 0.12.1 #65529

merged 1 commit into from Jul 29, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 28, 2019

Motivation for this change

Upgrade to latest upstream version, 0.12 -> 0.12.1.

Fixing the failed build due to pytest not being in checkInput.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lsix July 28, 2019 22:12
worldofpeace
worldofpeace suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you switch to using the pytest command in the checkPhase?

It would also be nice to say that you've changed the source to github in the commit msg.

@mmahut
poezio: 0.12 -> 0.12.1
f4ce788 
Moving the source to GitHub from dev.louiz.org.
@worldofpeace worldofpeace merged commit dbcb36a into NixOS:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@lsix lsix Awaiting requested review from lsix

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @worldofpeace