postgis: allow on Darwin #65460
Merged
postgis: allow on Darwin #65460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get PostGIS going on Darwin: 1. Add libiconv, as is often required. 2. Expand platforms to `platforms.all`. 3. Deal with PostGIS' quirky build system. PostGIS' configure.ac has the following gem: AC_MSG_RESULT([------------------------------------------------------------------------]) AC_MSG_RESULT([ WARNING: You have set the --prefix to '$prefix'. But we mostly ]) AC_MSG_RESULT([ ignore the --prefix. For your info, using the values determined from ]) AC_MSG_RESULT([ $PG_CONFIG we will be installing: ]) AC_MSG_RESULT([ * postgis shared library in $PGSQL_LIBDIR ]) AC_MSG_RESULT([ * postgis SQL files in $PGSQL_SHAREDIR/contrib/postgis-$POSTGIS_MAJOR_VERSION.$POSTGIS_MINOR_VERSION ]) AC_MSG_RESULT([ * postgis executables in $PGSQL_BINDIR ]) AC_MSG_RESULT([------------------------------------------------------------------------]) This is suggestive of some assumptions in the build system, which are revealed when building in Nix on Darwin: the build fails because the postgres binary cannot be found in the install prefix specified for postgis; vis. cc x -bundle_loader $POSTGIS_PREFIX/bin/postgres This bundle_loader parameter is only available on Darwin, and this problem doesn't appear to affect Linux systems. The solution presented here is to symlink the postgres binary where PostGIS expects it to be, and then remove it after the build completes.
ofborg
bot
added
6.topic: darwin
|
@GrahamcOfBorg build postgis |
|
|
|
Borg's build did succeed on Darwin. I actually don't remember what's status of the Darwin sandbox. I assume further improvements can be left for later (in any case I'd leave some time for others to react). |
kalbasit
reviewed
Jul 28, 2019
| ''; | ||
|
|
||
| # create aliases for all commands adding version information | ||
| postInstall = '' | ||
| rm $out/bin/postgres | ||
| for prog in $out/bin/*; do # */ |
There was a problem hiding this comment.
Although this is not a change in this PR, do you know why there's a */ comment here?
There was a problem hiding this comment.
That clearly seems to unbreak syntax highlighting in editors that get confused by /* on that same line. One can see similar ones all over nixpkgs.
marsam
reviewed
Jul 31, 2019
lrworth
force-pushed
the
fix/postgis-on-darwin
branch
from
b71f8e5
to
c1da476
Compare
marsam
approved these changes
Jul 31, 2019
kalbasit
approved these changes
Aug 1, 2019
|
@GrahamcOfBorg build postgis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #65452.
To get PostGIS going on Darwin:
platforms.all.PostGIS' configure.ac has the following gem:
This is suggestive of some assumptions in the build system which are
revealed when building in Nix on Darwin: the build fails because the
postgres binary cannot be found in the install prefix specified for
postgis; viz.
The bundle_loader parameter is only available on Darwin
ld, and thisproblem doesn't appear to affect Linux systems.
The solution presented here is to symlink the postgres binary where
PostGIS expects it to be, and then remove it after the build completes.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)