Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo-apenwarr: update to release 0.42 and added docs and checks #65457

Merged
merged 1 commit into from Sep 13, 2019
Merged

redo-apenwarr: update to release 0.42 and added docs and checks #65457

merged 1 commit into from Sep 13, 2019

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Jul 27, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@globin globin merged commit ec64d88 into NixOS:master Sep 13, 2019
@delroth delroth mentioned this pull request Sep 20, 2019
Merged
10 tasks
@delroth
Copy link
Contributor

delroth commented Sep 20, 2019

This broke the package build because the source URL does not exist. See https://hydra.nixos.org/build/100923596 . Fixing in #69165

I'm also slightly confused as to why beautifulsoup was copy-pasted for that package and not e.g. added in pkgs/development/python-modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @delroth @globin