Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: introduce NIX_PYTHONEXECUTABLE in order to set sys.executable #65454

Merged
merged 1 commit into from Jul 27, 2019
Merged

Python: introduce NIX_PYTHONEXECUTABLE in order to set sys.executable #65454

merged 1 commit into from Jul 27, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jul 27, 2019

This is needed in case of python.buildEnv to make sure sys.executable
does not point to the unwrapped executable.

Motivation for this change

Fixes issues mentioned in ec7f569

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Jul 27, 2019

Actually thinking of sending this straight to staging-next.

FRidh referenced this pull request Jul 27, 2019
@FRidh
python.buildEnv: use NIX_PYTHONPATH
ec7f569
@vcunat
Copy link
Member

vcunat commented Jul 27, 2019

Probably, as nixos-unstable is blocked on this. I know basically nothing around python paths, so I can't well review.

@FRidh FRidh changed the base branch from staging to staging-next July 27, 2019 09:25
@FRidh
Python: introduce NIX_PYTHONEXECUTABLE in order to set sys.executable
68a331b 
This is needed in case of `python.buildEnv` to make sure sys.executable
does not point to the unwrapped executable.
@FRidh FRidh merged commit bd47c57 into NixOS:staging-next Jul 27, 2019
@FRidh FRidh deleted the exe branch July 27, 2019 09:53
@timokau
Copy link
Member

timokau commented Jul 27, 2019

Seems to fix the sage test issues, at least when running the previously failing tests in isolation.

@vcunat
Copy link
Member

vcunat commented Jul 27, 2019

Sage succeeded on Hydra.

@FRidh FRidh mentioned this pull request Nov 12, 2019
Open
@bergkvist bergkvist mentioned this pull request May 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@vcunat vcunat Awaiting requested review from vcunat

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @vcunat @timokau