purple-libnotify-plus: init at 2018-05-30, as well as dependency #65426
Conversation
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "purple-events"; | ||
| version = "2017-08-25"; |
There was a problem hiding this comment.
Why not use https://github.com/sardemff7/purple-events/releases/tag/v0.99.1 ? It's only 4 commits behind master: sardemff7/purple-events@v0.99.1...master
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "purple-libnotify-plus"; | ||
| version = "2018-05-30"; |
There was a problem hiding this comment.
Same here: Why not use https://github.com/sardemff7/purple-libnotify-plus/releases/tag/v2.99.1 ? It's only 7 commits behind master: sardemff7/purple-libnotify-plus@v2.99.1...master
| configureFlags = [ "--with-purple-plugindir=${placeholder "out"}/lib/purple-2" ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = http://purple-libnotify-plus.sardemff7.net/; |
There was a problem hiding this comment.
Same here: Although upstream uses this URL as it's website as in the GitHub repo description, it redirects to the GitHub page, implying perhaps we should use the following:
| homepage = http://purple-libnotify-plus.sardemff7.net/; | |
| homepage = "https://github.com/sardemff7/purple-libnotify-plus"; |
Note the quotes added.
| configureFlags = [ "--with-purple-plugindir=${placeholder "out"}/lib/purple-2" ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = http://purple-events.sardemff7.net/; |
There was a problem hiding this comment.
Although upstream uses this URL as it's website as in the GitHub repo description, it gets redirected to the GitHub page, implying perhaps we should use the following:
| homepage = http://purple-events.sardemff7.net/; | |
| homepage = "https://github.com/sardemff7/purple-events"; |
Note the quotes added.
|
What say you @dtzWill ? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
| sha256 = "1mhg40swa12inkdhhxf6x9c45h2dijzvdlx1325zgvs2k1vv0a3k"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ autoreconfHook pkgconfig intltool ]; |
There was a problem hiding this comment.
In new expressions, pkg-config should be used instead of the pkgconfig alias.
| meta = with stdenv.lib; { | ||
| homepage = http://purple-events.sardemff7.net/; | ||
| description = "libpurple events handling plugin and library"; | ||
| license = licenses.gpl3; |
There was a problem hiding this comment.
gpl3 is unclear, use gpl3Plus or gpl3Only. See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.
stale
bot
removed
the
2.status: stale
|
@dtzWill Can you please address the review comments? Otherwise I would close this PR. |
| meta = with stdenv.lib; { | ||
| homepage = http://purple-libnotify-plus.sardemff7.net/; | ||
| description = "Plugin to provide libnotify interface to Pidgin and Finch"; | ||
| license = licenses.gpl3; |
|
|
||
| configureFlags = [ "--with-purple-plugindir=${placeholder "out"}/lib/purple-2" ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| sha256 = "0gh86dknzd064y2d8nck4p8r6ci23vwrlhgy1q75mmc0px94gz34"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ autoreconfHook pkgconfig intltool ]; |
There was a problem hiding this comment.
| nativeBuildInputs = [ autoreconfHook pkgconfig intltool ]; | |
| nativeBuildInputs = [ autoreconfHook pkg-config intltool ]; |
|
|
||
| configureFlags = [ "--with-purple-plugindir=${placeholder "out"}/lib/purple-2" ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
| meta = with stdenv.lib; { | |
| meta = with lib; { |
|
Closing due to unresponsive author. |
Motivation for this change
Message notifications!
Needs
purple-eventsas well, which maybe should be added to plugin listalongside
purple-libnotify-plusin order to use this.Doing so works, haven't tried only adding
purple-libnotify-plus(which might maybe possibly find or otherwise 'pull in'
purple-events).In retrospect I probably could have just used notify-send{,.sh} and the
command-execute plugin or something :P but this seems to work without
the fiddling :).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)