Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fastapi: init at 0.33.0 #65425

Merged
merged 5 commits into from
Jul 27, 2019
Merged

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Jul 26, 2019

Motivation for this change

Add Starlette and FastAPI ASGI based Python web frameworks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15 wd15 requested a review from FRidh as a code owner July 26, 2019 16:35
wd15 added 5 commits July 26, 2019 15:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wd15 wd15 force-pushed the python-starlette-init branch from cdc96f5 to b57f64f Compare July 26, 2019 19:45
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 26, 2019
@FRidh FRidh merged commit 124fb41 into NixOS:master Jul 27, 2019
@wd15 wd15 deleted the python-starlette-init branch February 28, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants