Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.07.16 -> 2019.07.27 #65443

Merged
merged 1 commit into from Jul 29, 2019
Merged

youtube-dl: 2019.07.16 -> 2019.07.27 #65443

merged 1 commit into from Jul 29, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 26, 2019

Motivation for this change

Update youtube-dl to the latest release.
https://github.com/ytdl-org/youtube-dl/releases/tag/2019.07.27
NOTE: Updates to youtube-dl should be backported, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mattmelling
Copy link
Contributor

Builds fine under nix-review, however youtube-dl failed for me until I unset PYTHONPATH, which seems unrelated to this change but I don't get the same issue with nix-shell -p youtube-dl.

@Mic92 Mic92 merged commit 8e2f04f into NixOS:master Jul 29, 2019
@Mic92
Copy link
Member

Mic92 commented Jul 29, 2019

There might be a collision between python2 and python3 in nix-review.

@Mic92
Copy link
Member

Mic92 commented Jul 29, 2019

backport:

[detached HEAD defa89f] youtube-dl: 2019.07.16 -> 2019.07.27
Author: xrelkd 46590321+xrelkd@users.noreply.github.com
Date: Sat Jul 27 07:37:45 2019 +0800

@xrelkd xrelkd deleted the update/youtube-dl branch July 29, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Fuuzetsu approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@Phreedom Phreedom Awaiting requested review from Phreedom

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @mattmelling @Mic92 @Fuuzetsu