pkgsStatic: override libunwind #65537
Conversation
| @@ -1,4 +1,4 @@ | |||
| { stdenv, version, fetch, cmake, fetchpatch }: | |||
| { stdenv, version, fetch, cmake, fetchpatch, enableShared ? true }: | |||
There was a problem hiding this comment.
The modified stdenv for pkgsStatic was recently extended to carry a static flag, this can be used for the default argument, making the explicit override in the static overlay unnecessary.
| { stdenv, version, fetch, cmake, fetchpatch, enableShared ? true }: | |
| { stdenv, version, fetch, cmake, fetchpatch, enableShared ? !(lib.hasAttr "static" stdenv) }: |
You could even take it one step further and remove enableShared and check the implicit parameter in the cmakeFlags directly.
There was a problem hiding this comment.
We definitely want these to be overridable, so providing enableShared is important.
There was a problem hiding this comment.
Do we? What is the use case for specifying this at individual package granularity?
There was a problem hiding this comment.
Perhaps it's not so important. Some users might want to fine tune which packages are static and which are shared (in some cases like kerberos, no static version is available). It's nice to have a specific flag for this, although you can always just override the stdenv being used.
Motivation for this change
Adds static override to LLVM
libunwind. Try:Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)