screamingfrogseospider: init at 12.4 #65437
Conversation
| version = "11.3"; | ||
| url = "https://download.screamingfrog.co.uk/products/seo-spider/screamingfrogseospider_${version}_all.deb"; | ||
| sha256 = "a6a7b9434dadcd0ca5d486df16386ce317ed7d4d2f7acc2730156e13859368f9"; | ||
| in stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Why did you felt like you need the let + in syntax? Why not just use everything inside mkDerivation?
There was a problem hiding this comment.
Honestly not sure, will push an update later to rectify this. Thanks for the feedback.
| @@ -0,0 +1,32 @@ | |||
| { stdenv, lib, fetchurl, dpkg, oraclejre }: | |||
There was a problem hiding this comment.
Just out of curiosity, other JREs don't work?
There was a problem hiding this comment.
At the time, only oraclejre and jetbrains jres had support for OpenJFX and the jetbrains jre straight up didn't work. IIRC at the time this was still in flux, so will review again given that it's been a few months.
mattmelling
force-pushed
the
screamingfrog
branch
from
7a347d1
to
c373ffc
Compare
mattmelling
force-pushed
the
screamingfrog
branch
from
c373ffc
to
737fda2
Compare
mattmelling
changed the title
|
I have addressed @doronbehar 's formatting comments. Left it using oraclejre as screamingfrog does not appear to be compatible with openjdk. |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unpriviledged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity. |
Motivation for this change
Adding package for Screaming Frog SEO Spider
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)