Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkerd: init at 2019-07-26 #65436

Merged
merged 1 commit into from Jul 28, 2019
Merged

linkerd: init at 2019-07-26 #65436

merged 1 commit into from Jul 28, 2019

Conversation

Gonzih
Copy link
Contributor

@Gonzih Gonzih commented Jul 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 26, 2019

@yurrriq you might be also interested in this one

@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 26, 2019

@GrahamcOfBorg build kubernetes-linkerd

@Gonzih Gonzih changed the title linkerd: Init at stable-2.4.0 kubernetes-linkerd: Init at stable-2.4.0 Jul 26, 2019
@yurrriq
Copy link
Member

yurrriq commented Jul 27, 2019

Should we just call this linkerd?

@Gonzih Gonzih changed the title kubernetes-linkerd: Init at stable-2.4.0 linkerd: Init at stable-2.4.0 Jul 27, 2019
@Gonzih Gonzih force-pushed the gonzih/linkerd branch 2 times, most recently from e06971c to 656609b Compare July 27, 2019 23:37
@Gonzih Gonzih changed the title linkerd: Init at stable-2.4.0 linkerd: Init at 065dd3ec9d4b84c90383b31be16ccadd34a8ab0d Jul 27, 2019
@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 27, 2019

Figured out how to build from source, seems like only 2 days ago this particular project was switched to go modules.

@ofborg ofborg bot requested a review from kalbasit July 27, 2019 23:51
@Gonzih Gonzih changed the title linkerd: Init at 065dd3ec9d4b84c90383b31be16ccadd34a8ab0d linkerd: Init at 2019-07-26 Jul 28, 2019
@ofborg ofborg bot requested a review from kalbasit July 28, 2019 00:48
@kalbasit kalbasit changed the title linkerd: Init at 2019-07-26 linkerd: init at 2019-07-26 Jul 28, 2019
@kalbasit
Copy link
Member

@GrahamcOfBorg build linkerd

@kalbasit kalbasit merged commit 184beb5 into NixOS:master Jul 28, 2019
@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 28, 2019 via email

@Gonzih Gonzih deleted the gonzih/linkerd branch July 28, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq left review comments

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gonzih @yurrriq @kalbasit