Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the prediction parameters when they are modified in the UI #2254

Merged
merged 4 commits into from
Jul 28, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jul 28, 2019

Fix #2239.

@pleroy pleroy added this to the Ferrari milestone Jul 28, 2019
prediction_steps_index_ = default_prediction_steps_index_;
}
} else {
enabled = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This else clause has no effect.
Let us just get rid of enabled, and use adaptive_step_parameters.HasValue which is now equivalent below (we display them only if they are there).

Name it at the call site, i.e., enabled : adaptive_step_parameters.HasValue.
Consider reordering the arguments so as not to have to name all the other parameters (booleans benefit from naming more often than other parameters).

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jul 28, 2019
@pleroy pleroy merged commit ba3c0d8 into mockingbirdnest:master Jul 28, 2019
pleroy added a commit to pleroy/Principia that referenced this pull request Jul 29, 2019
pleroy added a commit that referenced this pull request Jul 29, 2019
Restore the behaviour prior to #2254 for the target vessel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tolerance and steps settings are not preserved across scene changes
2 participants