blobmoji: Init at 2019-06-14-Emoji-12 #65507
Conversation
|
|
||
| installPhase = '' | ||
| mkdir -p $out/share/fonts/noto | ||
| cp NotoColorEmoji.ttf fonts/Blobmoji.ttf $out/share/fonts/noto |
There was a problem hiding this comment.
Should it be copying NotoColorEmoji.ttf to the output? Both files have the font name "Blobmoji"
[nix-shell:~/tmp/nixpkgs/nixpkgs]$ ls -lh result/share/fonts/noto/
total 16M
-r--r--r-- 1 root root 8.0M Dec 31 1969 Blobmoji.ttf
-r--r--r-- 1 root root 7.4M Dec 31 1969 NotoColorEmoji.ttf
I am concerned in two things
NotoColorEmoji.ttfclashing with noto color emoji.- Both font files fighting for the Blobmoji font name.
It seems that releases only include Blobmoji.ttf. That file being bigger also makes me think the NotoColorEmoji is a transient build artifact. Though, I wasn't able to figure it quickly.
There was a problem hiding this comment.
I'm aware of the potential conflict. But as blobmoji is just noto color with additional blobby emoji so it's unlikely somebody would use both at the same time.
There was a problem hiding this comment.
The thing is the filename is NotoColorEmoji, but the font name is Blobmoji Regular. I think (though I'm not sure) that this is an issue since both font files will respond to the Blobmoji Regular font name.
That is more confusing with the conflict with the presence of NotoColorEmoji.ttf file. The conflict breaks the assumption that the noto color emoji font (by name) is made available.
I'm not sure if either of @jtojnar or @worldofpeace would know more about issues this could cause (they recently worked on color emoji stuff).
There was a problem hiding this comment.
Fontconfig chooses a font based on distance from a vector of properties. File name is one of the matched properties but I doubt either of them would win based on that, unless the application explicitly asked for that file name. Not sure what happens when both have the same distance, would need to see the files. On the other hand, if NotoColorEmoji.ttf fits better, it could definitely win.
| enableParallelBuilding = true; | ||
|
|
||
| postPatch = '' | ||
| sed -i 's,^PNGQUANT :=.*,PNGQUANT := ${pngquant}/bin/pngquant,' Makefile |
There was a problem hiding this comment.
You should be able to use makeFlags = [ "PNGQUANT=pngquant" ]; instead of patching the file. Hopefully, they will default to this in the future like upstream Noto did.
Motivation for this change
Real emoji have curves! 馃槫
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)