Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fusiondirectory: Init at 1.3 #65511

Closed
wants to merge 1 commit into from
Closed

fusiondirectory: Init at 1.3 #65511

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 28, 2019

Motivation for this change

cc @joachifm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jul 28, 2019

@GrahamcOfBorg build fusiondirectory

mmahut
mmahut reviewed Jul 28, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -14383,6 +14383,8 @@ in
inherit (darwin.apple_sdk.frameworks) SystemConfiguration;
};

fusiondirectory = callPackage ../servers/web-apps/fusiondirectory { };

fusionInventory = callPackage ../servers/monitoring/fusion-inventory { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe keep the same formatting structure as fusionInventory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? FusionDirectory is not a monitoring tool, it's a webapp for managing LDAP trees.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thought they are related and I thought it would make sense to have the same naming structure (eg. fusionDirectory).

@dasJ dasJ closed this Feb 5, 2020
@dasJ dasJ deleted the init-fusiondirectory branch February 5, 2020 00:11
@bachp
Copy link
Member

bachp commented Apr 26, 2020

@dasJ What was the reason for closing this PR? I might also be interested in using fusiondirectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @mmahut @bachp