Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.matrix-appservice-irc: Init #65508

Closed
wants to merge 1 commit into from
Closed

nodePackages.matrix-appservice-irc: Init #65508

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 28, 2019

I know I didn't regenerate anything, but that leads to a lot of
conflicts if somebody with direct master access adds a package first.

Motivation for this change

I'm running my own IRC bridge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
nodePackages.matrix-appservice-irc: Init
4e37bf8 
I know I didn't regenerate anything, but that leads to a lot of
conflicts if somebody with direct master access adds a package first.
@pacien
Copy link
Contributor

pacien commented Jul 29, 2019

Already proposed in #62864, which also adds a wrapper and a module for matrix-appservice-irc.

@dasJ
Copy link
Member Author

dasJ commented Jul 30, 2019

Closing in favor of #62864

@dasJ dasJ closed this Jul 30, 2019
@dasJ dasJ deleted the init-matrix-appservice-irc branch July 30, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @pacien