Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/xfs: Add xfs_repair to the initrd #65506

Merged
merged 1 commit into from Jul 30, 2019
Merged

nixos/xfs: Add xfs_repair to the initrd #65506

merged 1 commit into from Jul 30, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 28, 2019

Motivation for this change

When having a corrupted xfs partition, the repair process may require the partition to be unmounted.
However, this is not possible for e.g. the root partition, so it has to be done offline.
This PR adds the relevant tool (xfs_repair) to the initrd (if an xfs fs is boot-relevant).
This also fixes #8820.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do something similar to what's done in f2fs

in this module

@dasJ dasJ changed the title nixos/stage-1: Add xfs_repair to the initrd nixos/xfs: Add xfs_repair to the initrd Jul 30, 2019
@dasJ
Copy link
Member Author

dasJ commented Jul 30, 2019

@worldofpeace @Mic92 Fixed and rebased

@Mic92 Mic92 merged commit e991f0d into NixOS:master Jul 30, 2019
@dasJ dasJ deleted the xfs-repair-initrd branch July 30, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xfs_repair is missing from initrd
3 participants
@dasJ @worldofpeace @Mic92