Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tome2: init at 2.4 #65438

Merged
merged 2 commits into from Sep 15, 2019
Merged

tome2: init at 2.4 #65438

merged 2 commits into from Sep 15, 2019

Conversation

cizra
Copy link
Contributor

@cizra cizra commented Jul 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bhipple
bhipple requested changes Jul 27, 2019
View reviewed changes
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
@cizra
Copy link
Contributor Author

cizra commented Jul 29, 2019

@bhipple Thanks, all fixed.

@aanderse aanderse changed the title Tome2 tome2: init at 2.4 Aug 31, 2019
aanderse
aanderse requested changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tome4 just isn't the same... 😉

If you have any questions or need any help please do not hesitate to ask 😄

pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
@cizra
Copy link
Contributor Author

cizra commented Sep 13, 2019

@aanderse Thanks, all fixed.

aanderse
aanderse requested changes Sep 15, 2019
View reviewed changes
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
pkgs/games/tome2/default.nix Outdated Show resolved Hide resolved
aanderse
aanderse approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@aanderse aanderse merged commit 6d9c0e3 into NixOS:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple requested changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cizra @bhipple @aanderse