Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluedevil: make bluez-qt a propagatedBuildInputs #65440

Closed
wants to merge 1 commit into from
Closed

bluedevil: make bluez-qt a propagatedBuildInputs #65440

wants to merge 1 commit into from

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Jul 26, 2019

Motivation for this change

The plasma bluetooth applet fails to show with the following error:

Error loading QML file: file:///nix/store/90rl8rq4dkgvj66w4b4ihs80x62cjf23-bluedevil-5.15.5/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/BluetoothApplet.qml:24:1: module "org.kde.bluezqt" is not installed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -11,4 +11,5 @@ mkDerivation {
bluez-qt ki18n kio kwindowsystem plasma-framework qtdeclarative kcoreaddons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go ahead and remove this from buildInputs.

@xvello
Copy link
Contributor Author

xvello commented Jul 27, 2019

Thanks @ttuegel for the fast review. Unfortunately, it seems my investigation was wrong, can you help me understand what's up here?

Rebuiding with nixos-rebuild -I nixpkgs=/home/xavier/git/nixpkgs/ switch on master

nix-store --query --references /nix/store/cpwm80gr1jgb0dxnwczqmmvak42amzbr-bluedevil-5.15.5|grep blue
/nix/store/k7rg6msl9sqxm1cp9jfbi3yd4912wjbd-bluez-qt-5.58.0
/nix/store/k88rfq08byn4mvj4bx0rc15dqkbj8c81-bluez-qt-5.58.0-bin
/nix/store/cpwm80gr1jgb0dxnwczqmmvak42amzbr-bluedevil-5.15.5

Bluetooth KCMs work OK, plasmoid shows:

Error loading QML file: file:///nix/store/cpwm80gr1jgb0dxnwczqmmvak42amzbr-bluedevil-5.15.5/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/BluetoothApplet.qml:24:1: module "org.kde.bluezqt" is not installed

Rebuidling on my branch

nix-store --query --references /nix/store/z841232bp8j8dfcsczkrzkwpsjwzn5ri-bluedevil-5.15.5 | grep blue
/nix/store/k7rg6msl9sqxm1cp9jfbi3yd4912wjbd-bluez-qt-5.58.0
/nix/store/k88rfq08byn4mvj4bx0rc15dqkbj8c81-bluez-qt-5.58.0-bin
/nix/store/4fj0vkx838b96jw46328n4cckggd5xyb-bluez-qt-5.58.0-dev
/nix/store/z841232bp8j8dfcsczkrzkwpsjwzn5ri-bluedevil-5.15.5

Same result:

Error loading QML file: file:///nix/store/z841232bp8j8dfcsczkrzkwpsjwzn5ri-bluedevil-5.15.5/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/BluetoothApplet.qml:24:1: module "org.kde.bluezqt" is not installed

Adding libsForQt5.bluez-qt to systemPackages (either master or branch)

All works OK

Do you know if adding bluez-qt as a system package changes how its plugin is registered? Even with explicit install, bluez does not appear in $QT_PLUGIN_PATH.

@ttuegel
Copy link
Member

ttuegel commented Jul 27, 2019

Even with explicit install, bluez does not appear in $QT_PLUGIN_PATH.

Those aren't plugins, they are Plasmoids which are QML widgets. When installed to the system profile, I would expect them to appear in /run/current-system/sw/lib/qt-5.12/qml. Unfortunately, QML widgets usually need to be installed system-wide: we can't use a wrapper as with plugins because there isn't an executable to wrap.

@xvello
Copy link
Contributor Author

xvello commented Jul 27, 2019

Thanks a lot, would it make sense to patch plasma5.nix then to get bluez-qt installed if bluetooth is enabled?

@xvello
Copy link
Contributor Author

xvello commented Aug 6, 2019

Closing in favor of #66226

@xvello xvello closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants