Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.nvim-typescript: Init at 2019-07-27 #65472

Closed
wants to merge 1 commit into from
Closed

vimPlugins.nvim-typescript: Init at 2019-07-27 #65472

wants to merge 1 commit into from

Conversation

nbardiuk
Copy link
Contributor

@nbardiuk nbardiuk commented Jul 27, 2019 •
edited

Motivation for this change

Add https://github.com/mhartington/nvim-typescript vim plugin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: vim label Jul 27, 2019
@FRidh
Copy link
Member

FRidh commented Jul 28, 2019

@GrahamcOfBorg eval

@nbardiuk nbardiuk closed this Jul 30, 2019
@lo1tuma
Copy link
Member

lo1tuma commented Jan 14, 2020

Are there any plans to add nvim-typescript to nixpkgs? Or why has this PR been closed?

@nbardiuk
Copy link
Contributor Author

@lo1tuma the PR has been closed because this code does not work. I've used more nix magic than I can debug 🙂

I don't have plans to work on this, feel free to pick it up

@bouk bouk mentioned this pull request Jun 5, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nbardiuk @FRidh @lo1tuma