Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcachefs/update-7 #67696

Merged
merged 2 commits into from Sep 28, 2019
Merged

bcachefs/update-7 #67696

merged 2 commits into from Sep 28, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from Chiiruno August 29, 2019 14:56
@Chiiruno
Copy link
Contributor

I'm having some overheating issues and no compressed air on hand, so I'll have to test this at a later date.
In the meantime...
@GrahamcOfBorg test bcachefs

Chiiruno
Chiiruno approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some compressed air!
Tested with nix-build nixos/tests/bcachefs.nix, all good!

@Chiiruno
Copy link
Contributor

@GrahamcOfBorg build linux_testing_bcachefs

@Chiiruno
Copy link
Contributor

Yeah sorry, I don't think I have permissions for that, we'll have to wait until someone with them can build/test/merge with the build bot.

Chiiruno
Chiiruno approved these changes Sep 7, 2019
View reviewed changes
Copy link
Contributor

@Chiiruno Chiiruno left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest with nix-build nixos/tests/bcachefs.nix, all good!
I think the checks are due to a hydra failure.

@ofborg ofborg bot requested review from Chiiruno and davidak September 27, 2019 20:25
Chiiruno
Chiiruno approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again as above.
Still good.

@davidak
Copy link
Member

davidak commented Sep 27, 2019

@GrahamcOfBorg test bcachefs

davidak
davidak approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not tested tho

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/59

@timokau
Copy link
Member

timokau commented Sep 28, 2019

Thanks all!

@timokau timokau merged commit 7cc78d4 into NixOS:master Sep 28, 2019
@eadwu eadwu deleted the bcachefs/update-7 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@Chiiruno Chiiruno Chiiruno approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @Chiiruno @davidak @nixos-discourse @timokau