Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] dovecot: 2.3.5.7 -> 2.3.7.2, pigeonhole: 0.5.5 -> 0.5.7.2 #67698

Merged
merged 9 commits into from Aug 29, 2019

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Aug 29, 2019

Motivation for this change

Dovecot minor versions should be upgradeable without any incompatibilities, so picking just the security patches risks missing some commits that are by themselves not security fixes, but are required for later security fixes. Moving to the current supported version also eases support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir @peti @rickynils @fpletz

@tokudan
Copy link
Contributor Author

tokudan commented Aug 29, 2019

@GrahamcOfBorg build dovecot dovecot_pigeonhole

@tokudan
Copy link
Contributor Author

tokudan commented Aug 29, 2019

@GrahamcOfBorg test dovecot

Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests passed locally.

@WilliButz WilliButz merged commit 95e7d97 into NixOS:release-19.03 Aug 29, 2019
@tokudan tokudan deleted the 1903/dovecot-major branch August 29, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants