New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.03] dovecot: 2.3.5.7 -> 2.3.7.2, pigeonhole: 0.5.5 -> 0.5.7.2 #67698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes CVE-2019-11494 and CVE-2019-11499 https://dovecot.org/pipermail/dovecot-news/2019-April/000408.html (cherry picked from commit 427dfad)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dovecot/versions (cherry picked from commit 5eb5740)
(cherry picked from commit e217309)
(cherry picked from commit d7582c9)
https://dovecot.org/pipermail/dovecot-news/2019-April/000411.html (cherry picked from commit c38b485)
(cherry picked from commit 4f38967)
This is a followup on NixOS#67623 (cherry picked from commit 46ff96c)
@GrahamcOfBorg build dovecot dovecot_pigeonhole |
@GrahamcOfBorg test dovecot |
andir
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tests passed locally.
WilliButz
approved these changes
Aug 29, 2019
fpletz
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dovecot minor versions should be upgradeable without any incompatibilities, so picking just the security patches risks missing some commits that are by themselves not security fixes, but are required for later security fixes. Moving to the current supported version also eases support.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @andir @peti @rickynils @fpletz