redis: Try to fix cross-compilation #67694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Note**: This makes redis use libc malloc when cross-compiling to ARM. This may or may not degrade performance. The reason for this is vendored jemalloc with Redis' patches. The makefile for deps has hardcoded configure flags for jemalloc, and as a result, it is unable to cross-compile it.
|
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.redis |
|
Glibc cannot be built. @matthewbauer can you restart? |
|
Actually that's aarch64-linux -> aarch64-linux cross compilation. That's not as important as x86_64-linux -> aarch64-linux compilation, which looks like it works: https://github.com/NixOS/nixpkgs/pull/67694/checks?check_run_id=207052152 |
|
By the way, a proper fix for this would be redis/redis#5670. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This makes redis use libc malloc when cross-compiling to ARM. This may or may not degrade performance.
The reason for this is vendored jemalloc with Redis' patches. The makefile for deps has hardcoded configure flags for jemalloc, and as a result, it is unable to cross-compile it.
This may be ugly, and may be rejected. There is an alternative, which is fixing the vendored jemalloc build and sending patches upstream, but I'm proposing this as a temporary fix.
The build for this is available at https://glovebox.fireburn.ru/job/nixos-armv7l/nixos-unstable/redis-libc-malloc, built against latest nixos-unstable channel.
Motivation for this change
Redis won't cross-compile, particularly for ARM. I'm trying to fix it here.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @globin @berdario