Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: add maintainer #67756

Merged
merged 1 commit into from Aug 30, 2019
Merged

firefox-bin: add maintainer #67756

merged 1 commit into from Aug 30, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Aug 30, 2019

Motivation for this change

As I have joined the Package Maintainer Team and the firefox-bin package have no maintainer.

Should I also add @edolstra and @andir, who are the maintainers of the firefox package? @adisbladis is also a candidate as they updates beta and deveditions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@adisbladis
Copy link
Member

Should I also add @edolstra and @andir, who are the maintainers of the firefox package?

No, the maintainership of -bin and source based derivations are completely separate for a reason.

@adisbladis is also a candidate as they updates beta and deveditions.

Yes, I'll add myself as a maintainer for this package.

@adisbladis adisbladis merged commit 371f741 into NixOS:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taku0 @adisbladis