Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colmap: init at 3.5 #67759

Merged
merged 4 commits into from
Aug 31, 2019
Merged

colmap: init at 3.5 #67759

merged 4 commits into from
Aug 31, 2019
+40 −0

Conversation

lebastr
Copy link
Contributor

@lebastr lebastr commented Aug 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@lebastr
colmap: init at 3.5

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b3c6a3b
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 30, 2019
alexarice
alexarice reviewed Aug 30, 2019
View reviewed changes
alexarice
alexarice suggested changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qt apps need to use qt's mkDerivation instead of stdenv.mkDerivation. Otherwise you get errors like

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""

alexarice
alexarice approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-review and both binaries run.
It gives a lot of errors of the form

qt.glx: qglx_findConfig: Failed to finding matching FBConfig (8 8 8 0)

I don't know if these are a problem. Might be more to do with setup of qt apps on my laptop

@lebastr
Copy link
Contributor Author

lebastr commented Aug 30, 2019 •
edited
Loading

I have no such errors. How do you run a colmap? I have tested

  1. colmapWithCuda on the server without gui using command:
    colmap automatic_reconstructor --image_path ./images/ --workspace_path ./
  2. colmap (without cuda) on my laptop:
    colmap gui

@alexarice
Copy link
Contributor

I just ran colmap gui. Honestly I think qt is set up really weirdly on my system because I have never managed to get any theme to work

@disassembler
Copy link
Member

@GrahamcOfBorg build colmap colmapWithCuda

@disassembler disassembler merged commit 35ac334 into NixOS:master Aug 31, 2019
@lebastr lebastr deleted the colmap branch August 31, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler

@alexarice alexarice

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lebastr @alexarice @disassembler