{ lib, buildPythonPackage, fetchPypi, isPy27
, futures
, gevent
, mock
, pytest
, tornado
}:

buildPythonPackage rec {
pname = "opentracing";
version = "2.2.0";

src = fetchPypi {
inherit pname version;
sha256 = "cfd231ba5c58f90bc277787e62861eb0c6e4af76e42957bec240bbdf71fb7e0e";
};

propagatedBuildInputs = lib.optional isPy27 futures;

checkInputs = [ gevent mock pytest tornado ];
checkPhase = ''
pytest
'';

meta = with lib; {
description = "This library is a Python platform API for OpenTracing";
homepage = "https://github.com/opentracing/opentracing-python";
license = licenses.asl20;
maintainers = with maintainers; [ rakesh4g ];
};
}

Thanks @jonringer. Yes it looks more appropriate. I will test this in my environment and update.

attaching the build_output along with test phase.
opentracing_build_with_tests.txt

I think you'll probably need to make the 7225cff commit (where you add yourself as maintainer) to be the first commit and then squash the rest into a second commit.

Build works for me though.

Result of nix-review pr 67760 1

I think you'll probably need to make the 7225cff commit (where you add yourself as maintainer) to be the first commit and then squash the rest into a second commit.

Build works for me though.

Result of nix-review pr 67760 1

2 packages were built:

Hi @wd15 , I have tried to update as suggested. Thanks.

Hi @wd15 , I have tried to update as suggested. Thanks.

You could also swap the order of the two remaining commits.

Hi @wd15 , I have tried to update as suggested. Thanks.

You could also swap the order of the two remaining commits.

ok @wd15 , Thanks i will do this.

Hi @wd15 , I have tried to update as suggested. Thanks.

You could also swap the order of the two remaining commits.

Hi @wd15, When i went to reverse the commit order, I realised that the order in my branch is already in reverse order (add maintainer first). But may be due to date difference it is not shown properly here.

> git log 
commit b871d8dd24451234f5db620873d3c4a40d00c7d3 (HEAD -> opentracing_python)
Author: Rakesh4G <rakeshgupta4u@gmail.com>
Date:   Fri Aug 30 20:44:50 2019 +1000

    python3Packages.opentracing: init at 2.2.0

commit 68fa9b6defa50ea19bfc16f0141a889a93c24fb0
Author: Rakesh4G <rakeshgupta4u@gmail.com>
Date:   Mon Sep 2 16:12:16 2019 +1000

    maintainers: add rakesh4g

Hi @wd15, When i went to reverse the commit order, I realised that the order in my branch is already in reverse order (add maintainer first). But may be due to date difference it is not shown properly here.

No worries then.

Is this ready to be merged?

@CMCDragonkai Yes, This is ready to be merged.

Hey can we get this merged?

to fix the commit history, please do:

git rebase -i HEAD~3
# then delete the middle wrong commit, and switch the other two lines/commits
git pull -r origin master  # to rebase on top of current master
# resolve conflicts
git add .
git rebase --continue

to fix the commit history, please do:

git rebase -i HEAD~3
# then delete the middle wrong commit, and switch the other two lines/commits
git pull -r origin master  # to rebase on top of current master
# resolve conflicts
git add .
git rebase --continue

OK, Thanks.

@GrahamcOfBorg build python27Packages.opentracing python37Packages.opentracing python38Packages.opentracing