Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains/update-2 #67719

Merged
merged 17 commits into from Sep 28, 2019
Merged

jetbrains/update-2 #67719

merged 17 commits into from Sep 28, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 29, 2019

JDK seems to work fine on Intellij. See #67539 and #65383.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo

@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

@GrahamcOfBorg eval

@eadwu
Copy link
Member Author

eadwu commented Sep 27, 2019

Updated.

@Mic92 Mic92 merged commit 492be34 into NixOS:master Sep 28, 2019
@eadwu eadwu deleted the jetbrains/update-2 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants