Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains/update-2 #67719

Merged
merged 17 commits into from
Sep 28, 2019
Merged

jetbrains/update-2 #67719

merged 17 commits into from
Sep 28, 2019
+27 −28

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 29, 2019 •
edited
Loading

JDK seems to work fine on Intellij. See #67539 and #65383.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo

Sorry, something went wrong.

@eadwu eadwu requested a review from edwtjo as a code owner August 29, 2019 19:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Aug 29, 2019
eadwu added 3 commits August 31, 2019 15:40
@eadwu
jetbrains.jdk: 164 -> 451

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
925abd0
@eadwu
jetbrains.datagrip: 2019.2.2 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
0b3e7a2
@eadwu
jetbrains.webstorm: 2019.1.3 -> 2019.2.1

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
308a8d3
@eadwu eadwu force-pushed the jetbrains/update-2 branch from cca6d76 to 308a8d3 Compare August 31, 2019 19:51
eadwu added 3 commits September 6, 2019 17:42
@eadwu
jetbrains.idea-community: 2019.2.1 -> 2019.2.2

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
a803e91
@eadwu
jetbrains.idea-ultimate: 2019.2.1 -> 2019.2.2

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
eaf2a81
@eadwu
jetbrains.rider: 2019.2.1 -> 2019.2.2

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
092f822
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

@GrahamcOfBorg eval

eadwu added 11 commits September 27, 2019 15:55
@eadwu
jetbrains.clion: 2019.2.1 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
2d0f8a0
@eadwu
jetbrains.datagrip: 2019.2.3 -> 2019.2.5

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
403dc59
@eadwu
jetbrains.goland: 2019.2.1 -> 2019.2.2

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
5ebf7e4
@eadwu
jetbrains.idea-community: 2019.2.2 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
a92aed3
@eadwu
jetbrains.idea-ultimate: 2019.2.2 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
2cffced
@eadwu
jetbrains.phpstorm: 2019.2.1 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
a440d6d
@eadwu
jetbrains.pycharm-community: 2019.2.1 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
ac3c6be
@eadwu
jetbrains.pycharm-professional: 2019.2.1 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
4b6774a
@eadwu
jetbrains.ruby-mine: 2019.2.1 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
f3d611f
@eadwu
jetbrains.webstorm: 2019.2.1 -> 2019.2.3

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
6b91398
@eadwu
jetbrains.jdk: 451 -> 485.1

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
c43c2d6
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Sep 27, 2019
@eadwu
Copy link
Member Author

eadwu commented Sep 27, 2019

Updated.

@Mic92 Mic92 merged commit 492be34 into NixOS:master Sep 28, 2019
@eadwu eadwu deleted the jetbrains/update-2 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @Mic92