Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix{Flakes,Unstable}/update-1 #67718

Merged
merged 2 commits into from Aug 30, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 29, 2019

Motivation for this change

No real point to having sandbox-fallback if it doesn't exist.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dywedir
Copy link
Member

dywedir commented Aug 30, 2019

Could you please update nixFlakes too?

@eadwu eadwu force-pushed the nixUnstable/2.3pre6779_31f5ecf branch from 65c7729 to 2327e29 Compare August 30, 2019 11:55
@eadwu eadwu changed the title nixUnstable: 2.3pre6779_324a5dc9 -> 2.3pre6779_31f5ecf nix{Flakes,Unstable}/update-1 Aug 30, 2019
@eadwu eadwu force-pushed the nixUnstable/2.3pre6779_31f5ecf branch from 2327e29 to 8060c1f Compare August 30, 2019 12:38
@eadwu eadwu force-pushed the nixUnstable/2.3pre6779_31f5ecf branch from 8060c1f to 786804a Compare August 30, 2019 12:40
@ofborg ofborg bot requested a review from edolstra August 30, 2019 12:56
@edolstra edolstra merged commit e6ab68b into NixOS:master Aug 30, 2019
@eadwu eadwu deleted the nixUnstable/2.3pre6779_31f5ecf branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants