Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/geolocation-API.idl #18717

Merged

Conversation

autofoolip
Copy link
Contributor

@autofoolip autofoolip commented Aug 28, 2019

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Source: https://github.com/tidoust/reffy-reports/blob/d6ebeec/whatwg/idl/geolocation-API.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/583016313

@foolip
Copy link
Member

foolip commented Aug 28, 2019

I think it's best to wait for w3c/geolocation-api#34 to land before merging this, to not have tests requiring GeolocationPosition and GeolocationCoordinates to be exposed, when that'll soon change again.

@foolip
Copy link
Member

foolip commented Sep 10, 2019

w3c/geolocation-api#34 is reflected here now.

@foolip foolip merged commit cf281b7 into web-platform-tests:master Sep 10, 2019
@foolip foolip deleted the reffy-reports/geolocation-API branch September 10, 2019 07:41
foolip added a commit that referenced this pull request Sep 10, 2019
Following #18717, which
added `[SecureContext]` to a few interfaces.
foolip added a commit that referenced this pull request Sep 10, 2019
Following #18717, which
added `[SecureContext]` to a few interfaces.
@foolip
Copy link
Member

foolip commented Sep 10, 2019

Right after this I was going to send a PR to rename the test, but when backing up a step to fix the commit message of bd4803e I accidentally committed directly to master in c717f05.

It's not a very review-worthy change, but I'll check for regressions on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants