Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slirp4netns: 0.3.0 -> 0.4.2 #67692

Merged
merged 1 commit into from Nov 13, 2019
Merged

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 29, 2019

Motivation for this change

Update the package to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @orivej

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build slirp4netns

@saschagrunert saschagrunert force-pushed the slirp4netns branch 2 times, most recently from 7364a6b to 523a801 Compare August 30, 2019 11:24
@saschagrunert saschagrunert changed the title slirp4netns: 0.3.0 -> 0.3.3 slirp4netns: 0.3.0 -> 0.4.1 Sep 1, 2019
@saschagrunert
Copy link
Member Author

Updated to 0.4.1, @orivej

@saschagrunert saschagrunert changed the title slirp4netns: 0.3.0 -> 0.4.1 slirp4netns: 0.3.0 -> 0.4.2 Oct 21, 2019
@saschagrunert
Copy link
Member Author

Updated to 0.4.2, @orivej @vdemeester

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

pkgs/tools/networking/slirp4netns/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/slirp4netns/default.nix Outdated Show resolved Hide resolved
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert mentioned this pull request Nov 12, 2019
10 tasks
@peterhoeg peterhoeg merged commit 8fa83bd into NixOS:master Nov 13, 2019
@saschagrunert saschagrunert deleted the slirp4netns branch November 13, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants