Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zerotierone: 1.4.2 -> 1.4.4 #67648

Merged
merged 1 commit into from Aug 28, 2019
Merged

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Update for latest version. See: https://github.com/zerotier/ZeroTierOne/releases/tag/1.4.4
Note the license change to BSL 1.1.

Tested working with my zerotier network.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sjmackenzie @zimbatm @ehmry @obadz

@zimbatm
Copy link
Member

zimbatm commented Aug 28, 2019

it's a shame about BSL but nothing we can do about it

@fadenb
Copy link
Contributor

fadenb commented Sep 6, 2019

I just noticed the license change when updating a test system using the unstable channel.

How do we usually handle such a change to an unfree license? Should this be added to the release notes that nobody is surprised that systems without nixpkgs.config.allowUnfree = true; no longer build?

@zimbatm
Copy link
Member

zimbatm commented Sep 7, 2019

Good question. It's a first for me too.

What happens is the user gets a breakage if allowUnfree is set to false. At that point I expect the user to look into the code. Is there anything we can do better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants